🇰🇷 한글 설명
Linux 커널의 mlx5e 드라이버에서 XDP 멀티-버퍼 프로그램이 bpf_xdp_pull_data() 또는 bpf_xdp_adjust_tail()을 호출하여 버퍼 레이아웃을 변경할 때, 해제된 fragment들이 드라이버 측에서 추적되지 않아 음수 참조 카운트 오류가 발생한다. MTU 변경 시 page release 중 WARNING 발생 및 시스템 불안정성을 초래한다.
💡 쉬운 설명
Mellanox 고속 네트워크 카드의 Linux 드라이버가 고속 패킷 처리 중 메모리 조각을 잘못 계산하여 메모리 오류가 발생한다. 패치는 모든 해제된 메모리 조각을 올바르게 추적하도록 수정한다.
🇺🇸 원문 (English)
In the Linux kernel, the following vulnerability has been resolved:
net/mlx5e: RX, Fix XDP multi-buf frag counting for legacy RQ
XDP multi-buf programs can modify the layout of the XDP buffer when the
program calls bpf_xdp_pull_data() or bpf_xdp_adjust_tail(). The
referenced commit in the fixes tag corrected the assumption in the mlx5
driver that the XDP buffer layout doesn't change during a program
execution. However, this fix introduced another issue: the dropped
fragments still need to be counted on the driver side to avoid page
fragment reference counting issues.
Such issue can be observed with the
test_xdp_native_adjst_tail_shrnk_data selftest when using a payload of
3600 and shrinking by 256 bytes (an upcoming selftest patch): the last
fragment gets released by the XDP code but doesn't get tracked by the
driver. This results in a negative pp_ref_count during page release and
the following splat:
WARNING: include/net/page_pool/helpers.h:297 at mlx5e_page_release_fragmented.isra.0+0x4a/0x50 [mlx5_core], CPU#12: ip/3137
Modules linked in: [...]
CPU: 12 UID: 0 PID: 3137 Comm: ip Not tainted 6.19.0-rc3+ #12 NONE
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.16.3-0-ga6ed6b701f0a-prebuilt.qemu.org 04/01/2014
RIP: 0010:mlx5e_page_release_fragmented.isra.0+0x4a/0x50 [mlx5_core]
[...]
Call Trace:
<TASK>
mlx5e_dealloc_rx_wqe+0xcb/0x1a0 [mlx5_core]
mlx5e_free_rx_descs+0x7f/0x110 [mlx5_core]
mlx5e_close_rq+0x50/0x60 [mlx5_core]
mlx5e_close_queues+0x36/0x2c0 [mlx5_core]
mlx5e_close_channel+0x1c/0x50 [mlx5_core]
mlx5e_close_channels+0x45/0x80 [mlx5_core]
mlx5e_safe_switch_params+0x1a5/0x230 [mlx5_core]
mlx5e_change_mtu+0xf3/0x2f0 [mlx5_core]
netif_set_mtu_ext+0xf1/0x230
do_setlink.isra.0+0x219/0x1180
rtnl_newlink+0x79f/0xb60
rtnetlink_rcv_msg+0x213/0x3a0
netlink_rcv_skb+0x48/0xf0
netlink_unicast+0x24a/0x350
netlink_sendmsg+0x1ee/0x410
__sock_sendmsg+0x38/0x60
____sys_sendmsg+0x232/0x280
___sys_sendmsg+0x78/0xb0
__sys_sendmsg+0x5f/0xb0
[...]
do_syscall_64+0x57/0xc50
This patch fixes the issue by doing page frag counting on all the
original XDP buffer fragments for all relevant XDP actions (XDP_TX ,
XDP_REDIRECT and XDP_PASS). This is basically reverting to the original
counting before the commit in the fixes tag.
As frag_page is still pointing to the original tail, the nr_frags
parameter to xdp_update_skb_frags_info() needs to be calculated
in a different way to reflect the new nr_frags.
📍 영향받는 시스템
Linux kernel 6.19-rc3 이상 / mlx5_core 드라이버가 로드된 Mellanox ConnectX 계열 NIC 호스트
⚔️ 공격 벡터
로컬 CAP_NET_ADMIN 권한 보유 사용자가 XDP BPF 프로그램 로드 및 MTU 변경으로 kernel 메모리 오류 트리거
🛡️ 대응 방법
Linux 커널을 수정 버전으로 업데이트 또는 mlx5_core 드라이버 패치 적용
🔧 검증 코드
위 명령어 결과가 0이면 오류가 없는 정상 상태이고, 0보다 크면 취약점이 존재하는 상태
dmesg | grep -E 'mlx5e_page_release_fragmented|page_pool.*WARNING' | wc -l